Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen static reserved identifiers errors on ambient declarations #13615

Closed
tinganho opened this issue Jan 21, 2017 · 1 comment
Closed

Loosen static reserved identifiers errors on ambient declarations #13615

tinganho opened this issue Jan 21, 2017 · 1 comment
Labels
Fixed A PR has been merged for this issue
Milestone
TypeScript 2.2

Comments

@tinganho
Copy link
Contributor

tinganho commented Jan 21, 2017 •
edited

I think #12065 just broke the selenium-webdriver definition:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/selenium-webdriver/index.d.ts#L2601

An example usage:

driver.findeElement(By.name('firstname')).sendKeys('Bob');

One solution is to loosen the error on ambient declarations?
@tinganho tinganho mentioned this issue Jan 21, 2017
Merged
@tinganho
Copy link
Contributor Author

Just submitted a PR in #13616.

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 21, 2017
@mhegazy mhegazy added this to the TypeScript 2.2 milestone Jan 21, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.2
Development

No branches or pull requests
2 participants
@tinganho @mhegazy