Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Format Options for JSX/TSX End of Tag Placement #12539

Open
mjbvz opened this issue Nov 28, 2016 · 1 comment
Open

Provide Format Options for JSX/TSX End of Tag Placement #12539

mjbvz opened this issue Nov 28, 2016 · 1 comment
Labels
Domain: Formatter The issue relates to the built-in formatter Help Wanted You can do this Suggestion An idea for TypeScript VS Code Tracked There is a VS Code equivalent to this issue
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 28, 2016

From microsoft/vscode#16018 @VanishingDante

For the following JSX/TSX code:

<div
    >
    <img
        />
</div>

The current formatting settings do nothing. There does not seem to be a way to control how the ending > is placed on lines.

We would like an additional formatting setting so that we can format the above code as:

<div>
    <img />
</div>

This formatting option would be helpful for elements with many attributes.

@adidahiya
Copy link
Contributor

If this gets implemented, please consider formatting the end of tag token to align with the start of the tag as per the jsx-alignment lint rule.

@mhegazy mhegazy added Suggestion An idea for TypeScript Domain: Formatter The issue relates to the built-in formatter Help Wanted You can do this labels Dec 15, 2016
@mhegazy mhegazy added this to the Community milestone Dec 15, 2016
@RyanCavanaugh RyanCavanaugh modified the milestones: Community, Backlog Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Formatter The issue relates to the built-in formatter Help Wanted You can do this Suggestion An idea for TypeScript VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

5 participants