Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Consider adding the SparseSimulator #518

Open
kuzminrobin opened this issue Feb 4, 2022 · 1 comment
Open

Consider adding the SparseSimulator #518

kuzminrobin opened this issue Feb 4, 2022 · 1 comment
Assignees
Labels
Area-API Issue concerns the API design of a library, such as style guide or design principles adherence. Kind-Enhancement New feature or request Pkg-Standard Issue relates to the Microsoft.Quantum.Standard package.

Comments

@kuzminrobin
Copy link
Contributor

After the SparseSimulator is added, consider adding to the QuantumLibraries the support for the SparseSimulator.
In particular

  • In Standard/src/Diagnostics/Emulation/Internal.cs consider replacing all the occurrences of QuantumSimulator with CommonNativeSimulator - the common base class for QuantumSimulator and SparseSimulator, such that both the QuantumSimulator and SparseSimulator are covered.
  • For all the occurrences of @Test("QuantumSimulator") consider adding (in the next line) also @Test("SparseSimulator"), such that the test is run on both simulators. See example in the .qs files of this PR.
@kuzminrobin kuzminrobin added the Kind-Enhancement New feature or request label Feb 4, 2022
@cgranade
Copy link
Contributor

cgranade commented Feb 4, 2022

To clarify slightly on the first point, I'm not sure that it makes sense to generalize that to support all native simulators. The emulation for DumpOperation is fairly specific to using the Choi–Jamiłkowski isomorphism to decompose state-level diagnostics from the full-state simulator into operation-level diagnostics, such that it would be a more significant feature to generalize that to allow visualizing unitary operations that are sparse in the computational basis.

@msoeken msoeken self-assigned this Feb 5, 2022
@msoeken msoeken added Area-API Issue concerns the API design of a library, such as style guide or design principles adherence. Pkg-Standard Issue relates to the Microsoft.Quantum.Standard package. labels Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area-API Issue concerns the API design of a library, such as style guide or design principles adherence. Kind-Enhancement New feature or request Pkg-Standard Issue relates to the Microsoft.Quantum.Standard package.
Projects
None yet
Development

No branches or pull requests

3 participants