Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Using nuget restore from .NET 5.0 no longer requires first updating ca-certificates #593

Open
ryanhill1 opened this issue Jan 31, 2022 · 1 comment
Labels
Kind-Maintenance Request or suggestion for general code quality improvements

Comments

@ryanhill1
Copy link

Quantum/Build/images/samples/Dockerfile lines 29-38 update ca-certificates package:

    # As per https://github.com/NuGet/Announcements/issues/49,
    # we also need to update the ca-certificates package
    # to use nuget restore from .NET 5.0.
    # This requries enabling debian-unstable, so we do so as a
    # separate command.
    cp /etc/apt/sources.list /etc/apt/sources.list.backup && \
    echo "deb https://deb.debian.org/debian unstable main" >> /etc/apt/sources.list && \
    apt-get -y update && \
    apt-get -y install ca-certificates=20211016 && \
    mv /etc/apt/sources.list.backup /etc/apt/sources.list && \

However, after looking through the updates of the above-linked NuGet issue, it seems that the Debian Family Linux distros that were originally impacted have since resolved the issues. Are lines 29-38 in the samples Dockerfile still necessary? Or am I wrong, and have these later Debian releases still not resolved all lingering issues?

@cgranade
Copy link
Contributor

Ah, thanks for flagging! We'll go on and remove that mitigation, then. @ricardo-espinoza, should we land this with the rest of .NET 6 support, do you think?

@cgranade cgranade added Kind-Bug Kind-Maintenance Request or suggestion for general code quality improvements and removed Kind-Bug labels Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Kind-Maintenance Request or suggestion for general code quality improvements
Projects
None yet
Development

No branches or pull requests

2 participants