Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_idn should not throw for virtual instruments #4611

Open
astafan8 opened this issue Sep 13, 2022 · 0 comments
Open

get_idn should not throw for virtual instruments #4611

astafan8 opened this issue Sep 13, 2022 · 0 comments

Comments

@astafan8
Copy link
Contributor

Virtual instruments should either override get_idn to not fail and respond with something useful, or we should rework this so get_idn is not implemented like this for the generic class.

the reason for the failure is that get_idn calls .ask which is not implemented for virtual instruments.

An example of this issue is in #4590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@astafan8