Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MRTK3 packages so that dependencies include the "-pre.X" tag. Without this dependency downloads fail #11607

Closed
2 tasks done
AMollis opened this issue Jun 8, 2023 · 0 comments

Comments

@AMollis
Copy link
Member

AMollis commented Jun 8, 2023

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:


Overview

When working on the new release pipeline, package.json dependencies had their "-pre.X" removed.

Not having these tags breaks dependency downloads from the feature tool and the scoped registry.

Please add the -pre.X tags back.

Additional Context

For example, in the pre.15 release the audio package had this.

  "dependencies": {
    "com.microsoft.mrtk.core": "3.0.0-pre.15"
  }

In pre.16 the audio package had this

  "dependencies": {
    "com.microsoft.mrtk.core": "3.0.0"
  }

In pre.16 the audio package doesn't successfully download dependencies.

Workaround

Manually select and download dependency packages via the Mixed Reality Feature Tool.

Tasks

  • Update pipeline
  • Create manual test to test this for futures
@github-actions github-actions bot added the MRTK3 label Jun 8, 2023
@AMollis AMollis changed the title Fix MRTK3 Pipeline so that dependencies include the "-pre.X" tag. Without this dependency downloads fail Fix MRTK3 package so that dependencies include the "-pre.X" tag. Without this dependency downloads fail Jun 8, 2023
@AMollis AMollis added this to the MRTK v3.0 GA milestone Jun 8, 2023
@AMollis AMollis changed the title Fix MRTK3 package so that dependencies include the "-pre.X" tag. Without this dependency downloads fail Fix MRTK3 packages so that dependencies include the "-pre.X" tag. Without this dependency downloads fail Jun 8, 2023
@shaynie shaynie closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants