Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRTK3 HandConstraintPalmUp doesn't default to head gaze for uncalibrated users #11092

Closed
camnewnham opened this issue Oct 9, 2022 · 3 comments

Comments

@camnewnham
Copy link

camnewnham commented Oct 9, 2022

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:


Describe the bug

When the app has gaze permission enabled but the user is uncalibrated (declines prompt to calibrate) the Gaze controller remains at the origin, but appears to still be considered active.

As a result, the HandConstraintPalmUp only triggers if the user happens to be looking in the same direction as the default.

https://github.com/microsoft/MixedRealityToolkit-Unity/blob/mrtk3/com.microsoft.mrtk.spatialmanipulation/Solvers/HandConstraintPalmUp.cs#L268-L290

Or have I miswired something?

MRTK 3.0.0-pre.11

MixedRealityOpenXRPlugin 1.5.1

@camnewnham camnewnham added the Bug label Oct 9, 2022
@github-actions github-actions bot added the MRTK3 label Oct 9, 2022
@camnewnham
Copy link
Author

It seems that InputTrackingState is not None if eyes are untracked (visor flipped up) as well (this does not affect the hand menu, but has other considerations)

@Zee2
Copy link
Contributor

Zee2 commented Oct 10, 2022

HandConstraintPalmUp is being totally re-jiggered in this PR: #10852 . Will be totally redone and optimized for head gaze!

@camnewnham
Copy link
Author

HandConstraintPalmUp is being totally re-jiggered in this PR: #10852 . Will be totally redone and optimized for head gaze!

Oh, nice! That looks great.

Perhaps the separate (or more appropriate) issue here is that GazeController is reporting a non-None trackingstate when the user isn't calibrated or the eye tracking isn't current (visor flipped up, headset off, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants