Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to load NuGet SDKs in dotnet format #88

Closed
rainersigwald opened this issue Apr 16, 2020 · 5 comments
Closed

Failure to load NuGet SDKs in dotnet format #88

rainersigwald opened this issue Apr 16, 2020 · 5 comments

Comments

@rainersigwald
Copy link
Member

@rainersigwald Rainer Sigwald FTE if you run the command below

dotnet tool install -g dotnet-format --version 4.0.121404 --add-source https://dotnet.myget.org/F/format/api/v3/index.json

and then run this command over this repo: https://github.com/dotnet/tye

dotnet-format -w tye.sln -v diag

you should get a bin log. Would be very curious to get a second opinion on what is happening here

from dotnet/format#584 (comment)

I reproduce with these instructions but haven't dug in.

@JoeRobich
Copy link
Member

@sharwell Found that the NuGetSdkResolver wouldn't load unless we added a local dependency on Newtonsoft.Json. I'm not yet sure why the AssemblyLoader that we use couldn't resolve it from the SDK folder as it does other MSBuild dependencies.

@YuliiaKovalova
Copy link
Contributor

@rainersigwald , it this issue still relevant?
image

@baronfel
Copy link
Member

dotnet format is shipped in the SDK these days, and I've successfully used it on many projects - I'm leaning towards this is probably not relevant anymore.

@JoeRobich
Copy link
Member

Can confirm that we have not had recent reports of this issue.

@YuliiaKovalova
Copy link
Contributor

Close as not relevant anymore.
Thank you for your responses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants