Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of node APIs #9506

Open
4 of 7 tasks
Tracked by #8725
tylerbutler opened this issue Mar 16, 2022 · 0 comments
Open
4 of 7 tasks
Tracked by #8725

Review use of node APIs #9506

tylerbutler opened this issue Mar 16, 2022 · 0 comments
Assignees
Labels
area: dev experience Improving the experience of devs building on top of fluid epic An issue that is a parent to several other issues
Milestone

Comments

@tylerbutler
Copy link
Member

tylerbutler commented Mar 16, 2022

This issue is to track the work related to fully addressing #8725. I'm opening a new issue since #8725 has a lot of discussion on it already.

Issues

Next

  • Review list and decide, for each, what the "policy" should be for the library.
  • Look at complete dependency chain for the 3P libraries and ensure they're all implicit-dependency free.
  • Use the browser field instead of main for packages that are intended to run in the browser (e.g. examples, anything that uses webpack in the build).

Policy options

  1. We shouldn't use the library -- either replace it with an isomorphic implementation, add explicit polyfill dependencies, or remove usage completely.
  2. Using the library in test code is ok. Usage of the node libraries should be explicitly identified.
@tylerbutler tylerbutler added the area: dev experience Improving the experience of devs building on top of fluid label Mar 16, 2022
@tylerbutler tylerbutler added this to the April 2022 milestone Mar 16, 2022
@tylerbutler tylerbutler self-assigned this Mar 16, 2022
@tylerbutler tylerbutler modified the milestones: April 2022, March 2022 Mar 16, 2022
@tylerbutler tylerbutler mentioned this issue Mar 25, 2022
2 tasks
@tylerbutler tylerbutler removed this from the March 2022 milestone Mar 30, 2022
@tylerbutler tylerbutler added the epic An issue that is a parent to several other issues label Apr 12, 2022
@tylerbutler tylerbutler added this to the May 2022 milestone Apr 12, 2022
@skylerjokiel skylerjokiel modified the milestones: May 2022, Next Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dev experience Improving the experience of devs building on top of fluid epic An issue that is a parent to several other issues
Projects
Status: In Progress
Development

No branches or pull requests

2 participants