You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
findTile method in mergeTree and client. This API locates the tile nearest to a given start position in a string in either the forward or backward direction.
Context
This API utilizes accelerated search functions to achieve a log(n) complexity, but those functions have a number of bugs and produce odd behavior in certain cases. Any users of this API have to implement various workarounds to get the functionality that they actually want. When comparing the tile returned by this method with those returned by the forwardExcursion or backwardExcurson methods, which have much more test coverage and are much more likely to return the intended tile, the results do not match up.
Approach findTile will be replaced by searchForMarker, which utilizes depthFirstNodeWalk instead of searchBlock and backwardSearchBlock. Test coverage for the new API will also be improved. The PR that takes care of the deprecation is #16517.
Dependencies
None.
Compatibility Concerns
None.
Phases
Deprecate findTile and add searchForMarker.
Improve test coverage of searchForMarker.
Replace all usages of findTile with searchForMarker in partner repos.
Remove findTile in mergeTree and client, as well as associated tests.
Remove non-exported functions/interfaces that are only used in findTile: IReferenceSearchInfo, recordTileStart, tileShift
Expected Timeline
The API will likely be removed in the 2.0.0-internal.7.0.0 release (the next major release).
Open Questions
None.
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!
Deprecated API
findTile
method in mergeTree and client. This API locates the tile nearest to a given start position in a string in either the forward or backward direction.Context
This API utilizes accelerated search functions to achieve a log(n) complexity, but those functions have a number of bugs and produce odd behavior in certain cases. Any users of this API have to implement various workarounds to get the functionality that they actually want. When comparing the tile returned by this method with those returned by the
forwardExcursion
orbackwardExcurson
methods, which have much more test coverage and are much more likely to return the intended tile, the results do not match up.Approach
findTile
will be replaced bysearchForMarker
, which utilizesdepthFirstNodeWalk
instead ofsearchBlock
andbackwardSearchBlock
. Test coverage for the new API will also be improved. The PR that takes care of the deprecation is #16517.Dependencies
None.
Compatibility Concerns
None.
Phases
findTile
and addsearchForMarker
.searchForMarker
.findTile
withsearchForMarker
in partner repos.findTile
in mergeTree and client, as well as associated tests.Expected Timeline
The API will likely be removed in the 2.0.0-internal.7.0.0 release (the next major release).
Open Questions
None.
The text was updated successfully, but these errors were encountered: