Enable IsAotCompatible for CsWinRT, fix all AOT warnings #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
user/sergiopedri/guard-mgt-calls
branch
from
1859080
to
77dc17a
Compare
Sergio0694
force-pushed
the
user/sergiopedri/guard-mgt-calls
branch
2 times, most recently
from
926fcab
to
47257fd
Compare
This was
linked to
issues
Jan 26, 2024
Sergio0694
force-pushed
the
user/sergiopedri/guard-mgt-calls
branch
2 times, most recently
from
3d62d49
to
6f3c77e
Compare
Sergio0694
force-pushed
the
user/sergiopedri/guard-mgt-calls
branch
2 times, most recently
from
b473692
to
6b5e475
Compare
manodasanW
approved these changes
Mar 11, 2024
* Fix build breaks from AOT warning fixes * Improvements to GUID helper type lookup to avoid needing instantiated generic type * Move around where helper type is initialized to handle more scenarios * Remove commented code
Sergio0694
force-pushed
the
user/sergiopedri/guard-mgt-calls
branch
from
c9f467a
to
05d472f
Compare
* Experiment with changes to avoid nullable.value going down the helper type route * Fix build * Fix nullable structs and delegates * Fix * Fix tests * Fix issue where the class implementing the interface can be trimmed and we rely on IDIC cast to create an instance of the interface. But that doesn't work with the interface inherits generic interfaces on AOT. This addresses that by making sure there is a fallback class available to use for the interface. * Fix warning * Improvements to nullable scenario (caching and removing old code paths) * Move where we do generic type initialization for derived generic interfaces impl class * Fix issue with Interface<> missing in impl classes by converting most of the remaining ones using it to the new format * Add test * PR feedback * PR feedback for IID
Sergio0694
force-pushed
the
user/sergiopedri/guard-mgt-calls
branch
from
05d472f
to
306fb63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1433, #1324
This PR includes some changes to finally fix all AOT warnings on CsWinRT:
IsAotCompatibleon the .NET 8 TFM[RequiresDynamicCode]annotations and suppressionsManagedIPropertyValueImpl.UnboxValueAOT-safe and remove undefined behavior