Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compare float and str #6

Open
cesaSalaam opened this issue Aug 17, 2021 · 3 comments
Open

Cannot compare float and str #6

cesaSalaam opened this issue Aug 17, 2021 · 3 comments

Comments

@cesaSalaam
Copy link

In the pre_gcm.py file, on line 49 that says
if 3 < l1len <= 100 and 3 < l2len <= 100 and pfms_score <= max_pfms:

this will produce an error because you are comparing a float (the pfms_score) and a str (max_pfms). Should convert max_pfms to float so that comparison can work

@mohdsanadzakirizvi
Copy link
Contributor

I think we're handling it somewhere, did you face an issue because of this?

@cesaSalaam
Copy link
Author

I did face a problem there, yes.

@mohdsanadzakirizvi
Copy link
Contributor

Could you please provide steps to recreate the issue so that I can verify?

Specifically, your config.ini values and the error thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants