Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The given example is not working #5

Open
Anwarvic opened this issue Aug 3, 2021 · 1 comment
Open

The given example is not working #5

Anwarvic opened this issue Aug 3, 2021 · 1 comment

Comments

@Anwarvic
Copy link

Anwarvic commented Aug 3, 2021

Hi all,

Thank you for the effort taken to create this tool, it's really helpful.

I clone your repo and installed the dependencies and everything looks fine. I tried the Web UI method using the provided example (Hindi-English) and it's not working. And when I dug a little bit into the code, I found a lot of problems. For example,

The generate button calls a function called run_gcm() which runs a whole python script called sequence_run.py which runs another script called pre_gcm.py. In pre_gcm.py file, we can see that the main() function is getting called when we run the script with an empty argument when it's supposed to be a parsed sentence.

Is this a bug? or I missed something.
Also, is this tool stable for usage, or it is still under development?

Either way, thank you for your efforts!

@mohdsanadzakirizvi
Copy link
Contributor

Hi Anwar,

The code that you've referenced is alright, it's designed that way. We don't call function main() with params because we know the value of those params from the config.ini file.

Sometimes if the quality of alignments aren't good, the GCM gives an empty output. Is this the issue you're facing?

  1. How did you generate the alignments?
  2. Did you try it for a bunch of different Hindi-English sentences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants