Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on p-defer-es5 #5165

Open
nick-pape opened this issue May 3, 2024 · 0 comments
Open

Missing dependency on p-defer-es5 #5165

nick-pape opened this issue May 3, 2024 · 0 comments
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@nick-pape
Copy link

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Latest production

Which distribution are you using Web Chat from?

Bundle (webchat.js)

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

No response

Which area does this issue affect?

Development experience

Which theme pack does this issue affect?

I did not test it on other theme packs

What is the public URL for the website?

No response

Please describe the bug

Several pieces of code in this package import p-defer-es5 directly. However, this package is not listed in dependencies in package.json. This causes an issue with installers such as pnpm as they don't "flatten" the node_modules. Specifically, this is causing an issue in ODSP codebase. Please add p-defer-es5 as a dependency. Thanks!

Do you see any errors in console log?

No response

How to reproduce the issue?

  1. Use pnpm to install this package
  2. Try to run/webpack the code

What do you expect?

Webpack to succeed

What actually happened?

Webpack is unable to import p-defer-es5

Do you have any screenshots or recordings to repro the issue?

No response

Adaptive Card JSON

No response

Additional context

No response

@nick-pape nick-pape added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

No branches or pull requests

1 participant