Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The alert icon is incorrectly displayed as an empty square when the key value is empty for one app configuration #7674

Closed
v-xianya opened this issue Jan 15, 2024 · 3 comments
Assignees
Labels
⚙️ app-config Related to App Configuration extension 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Milestone

Comments

@v-xianya
Copy link
Member

Storage Explorer Version: 1.33.0-dev (96)
Build Number: 20240113.2
Branch: main
Platform/OS: Windows 10/MacOS Sonoma 14.2(Apple M1 Pro)
Architecture: x64/arm64
App Config Version: 0.2.1
How Found: From running test cases
Regression From: Not a regression

Steps to Reproduce

  1. Expand App Configurations -> Open one app configuration.
  2. Click 'Add' -> Type a value in the key field then empty the field.
  3. There is an alert message.
  4. Check the alert icon shows well.

Expected Experience

The alert icon shows well.
image

Actual Experience

Show an empty square instead of an alert icon.
image

Additional Context

This issue doesn't reproduce when installing App Configuration 0.2.0.

@v-xianya v-xianya added 🧪 testing Found through regular testing ⚙️ app-config Related to App Configuration extension labels Jan 15, 2024
@MRayermannMSFT MRayermannMSFT added this to the 1.33.0 milestone Jan 15, 2024
@craxal craxal added the ✅ merged A fix for this issue has been merged label Jan 24, 2024
@v-xianya
Copy link
Member Author

Verified this issue on the main build 20240124.4. Reproduce.

@craxal
Copy link
Contributor

craxal commented Jan 25, 2024

@v-xianya This work item is marked as Verifying, meaning it's not Done yet. We still need to update the package before it can be closed.

@MRayermannMSFT MRayermannMSFT modified the milestones: 1.33.0, 1.34.0 Mar 4, 2024
@craxal craxal closed this as completed Mar 4, 2024
@craxal craxal modified the milestones: 1.34.0, 1.33.0 Mar 4, 2024
@v-xianya
Copy link
Member Author

v-xianya commented Mar 6, 2024

Verified this issue on the main build 20240305.7 with App configuration 0.2.2. Fixed.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ app-config Related to App Configuration extension 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

3 participants