Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add real functional tests for decimal places of numbers formatted by system format #7297

Closed
JasonYeMSFT opened this issue Sep 13, 2023 · 2 comments
Assignees
Labels
🧪 engineering Related to some internal engineering improvements ✅ merged A fix for this issue has been merged
Milestone

Comments

@JasonYeMSFT
Copy link
Contributor

No description provided.

@JasonYeMSFT JasonYeMSFT added this to the 1.33.0 milestone Sep 13, 2023
@JasonYeMSFT JasonYeMSFT added the 🧪 engineering Related to some internal engineering improvements label Sep 13, 2023
@craxal
Copy link
Contributor

craxal commented Sep 18, 2023

@JasonYeMSFT @MRayermannMSFT Can we narrow in on the scope of tests being asked for? This is not trivial. Open to ideas, but the trick will be being able to predict the locale and format settings of the test machine. I would think we would want to use different settings to test other formats as well, which makes writing these even harder.

@JasonYeMSFT JasonYeMSFT changed the title Add real functional tests for system format Add real functional tests for decimal places of numbers formatted by system format Sep 19, 2023
@JasonYeMSFT
Copy link
Contributor Author

JasonYeMSFT commented Sep 19, 2023

I updated the title. We are interested in testing the number of digits after the decimal points if we explicitly specify how many digits to use, which doesn't depend on the local setting of the build agent.

@craxal craxal added the ✅ merged A fix for this issue has been merged label Jan 24, 2024
@craxal craxal closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 engineering Related to some internal engineering improvements ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

2 participants