Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No notification message appears after deleting date in Start time box on 'Manage Access Policies' dialog #3014

Closed
v-xianya opened this issue May 21, 2020 · 1 comment
Assignees
Labels
🪲 regression Issue was working in a previous version 🧪 testing Found through regular testing ✅ by design Issue is intentional (not a bug)
Milestone

Comments

@v-xianya
Copy link
Member

Storage Explorer Version: 1.14.0-dev
Build: 20200521.3
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 16.04/ macOS Mojave
Architecture: ia32/x64
Regression From: Previous release (1.13.0)

Steps to reproduce:

  1. Expand one storage account -> Blob Containers.
  2. Select one blob container and open its context menu -> Click 'Manage Access Policies...'.
  3. Click 'Add' -> Delete one date value in Start time box then hover over on it.
  4. Check whether there appears a notification message or not.

Expect Experience:
A notification message appears.
image

Actual Experience:
No notification message appears.

More Info:
This issue also reproduces for one file share/ table.

@v-xianya v-xianya added 🧪 testing Found through regular testing 🪲 regression Issue was working in a previous version labels May 21, 2020
@MRayermannMSFT MRayermannMSFT added this to the 1.14.0 milestone May 27, 2020
@JasonYeMSFT JasonYeMSFT added this to Investigating in Storage Explorer May 29, 2020
@MRayermannMSFT MRayermannMSFT modified the milestones: 1.14.0, 1.15.0 Jun 1, 2020
@JasonYeMSFT
Copy link
Contributor

The has been a Chromium behavior change introduced since Electron 5.0.0. When a title="" (tooltip) is provided to to the input element, the element will privilege the tooltip instead of showing a built-in error message.

Incomplete date time value is equivalent to empty date time. For us, this is by design since we now allow the start/expiry time to be empty because of #764. So we won't add an error message to this input element because the value is valid to be empty.

@JasonYeMSFT JasonYeMSFT added the ✅ by design Issue is intentional (not a bug) label Jul 24, 2020
@JasonYeMSFT JasonYeMSFT moved this from Investigating to Verifying in Storage Explorer Jul 24, 2020
Storage Explorer automation moved this from Verifying to Done Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 regression Issue was working in a previous version 🧪 testing Found through regular testing ✅ by design Issue is intentional (not a bug)
Projects
Development

No branches or pull requests

3 participants