Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No default Start time and Expiry time display on 'Access Policies' dialog #1085

Closed
v-xuanzh opened this issue Jan 23, 2019 · 3 comments
Closed
Labels
🧪 testing Found through regular testing ✅ by design Issue is intentional (not a bug)

Comments

@v-xuanzh
Copy link

Storage Explorer Version: 1.6.2_20190123.3
Platform/OS Version: Windows x64/Linux Ubuntu 16.04/MacOS High Sierra
Architecture: ia32
Commit:e412c857
Regression From: Previous release 1.6.2

Steps to Reproduce:

  1. Choose one non adls gen2 account ->Right click one blob container then select 'Manage Access Policies...'.
  2. Click 'Add' -> Check the Start time and Expiry time for the added accees policy -> Save.
  3. Right click the same blob container then select 'Get Shared Access Signature...' -> Select the added ploicy on the dropdown list -> Check the Start time and Expiry time on the SAS dialog.

Expected Experience:

Step2: Show the default Start time and Expiry time on the 'Access Policies' dialog.
Step3: SAS dialog shows the same Start time and Expiry time with default.

Actual Experience:

Step2: There is no default Start time and Expiry time.
image

Step4: Only shows the Expiry time on SAS dialog.
image

@v-xuanzh v-xuanzh added 🧪 testing Found through regular testing 🪲 regression Issue was working in a previous version labels Jan 23, 2019
@craxal craxal added ✅ by design Issue is intentional (not a bug) and removed 🪲 regression Issue was working in a previous version labels Jan 23, 2019
@craxal
Copy link
Contributor

craxal commented Jan 23, 2019

By design. Access policies do not need expiry or start times. This was done to fix #764.

@craxal craxal closed this as completed Jan 23, 2019
@v-xuanzh
Copy link
Author

@craxal ,
Also, the default expiry time with the current time shows on SAS dialog when selecting the set access policy(no start time and expiry time). Is it by design?
image

@craxal
Copy link
Contributor

craxal commented Jan 24, 2019

No, but we're going to revert changes made here due to too many regressions. See #1092, #1093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 testing Found through regular testing ✅ by design Issue is intentional (not a bug)
Projects
None yet
Development

No branches or pull requests

2 participants