Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Start time doesn't support ms. #72

Open
acollard opened this issue Oct 30, 2019 · 2 comments · May be fixed by #73
Open

Start time doesn't support ms. #72

acollard opened this issue Oct 30, 2019 · 2 comments · May be fixed by #73

Comments

@acollard
Copy link

This makes is pretty much useless when comparing telemetry events.

The ISO string returned from this utility is only accurate to the second.

$envelope->setTime(Contracts\Utils::returnISOStringForTime($startTime));

And all start times should use microtime();

Actual Behavior

Start times are truncated at seconds.

Expected Behavior

All times should be accurate to at least milliseconds.

Workaround

We've had to implement a workaround right before flushing. We store the start_time in microseconds, then rewrite the start time right before flushing.

@acollard
Copy link
Author

acollard commented Oct 30, 2019

I will try to put together a PR with the fixes.

This will require some breaking changes as all start times will now need to be in milliseconds.

@acollard acollard linked a pull request Oct 30, 2019 that will close this issue
@acollard
Copy link
Author

This shouldn't break any code as passing in a time() will just ignore the milliseconds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant