Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rendering][XAML] ChoiceSets without a Label have no accessible name #8837

Open
krschau opened this issue Feb 27, 2024 · 0 comments
Open

[Rendering][XAML] ChoiceSets without a Label have no accessible name #8837

krschau opened this issue Feb 27, 2024 · 0 comments

Comments

@krschau
Copy link
Collaborator

krschau commented Feb 27, 2024

Target Platforms

UWP

SDK Version

1.5

Application Name

Dev Home

Problem Description

If a Label (Header) is not specified on a ChoiceSet (ComboBox), the resulting ComboBox will not have an accessible name. This is the same behavior that happens in direct WinUI 3, however, setting an Accessible Name directly in WinUI 3 is a lot easier than hoping each Adaptive Card host creates a custom renderer for this case. I suggest that if there is no Label, the renderer sets the Name to be the placeholder text. That way the card author can still do things the default way (set a label/header) but the control is still accessible if they do not.

https://dev.azure.com/microsoft/OS/_workitems/edit/48294659
https://dev.azure.com/microsoft/OS/_workitems/edit/48181033

Screenshots

No response

Card JSON

{
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5",
    "body": [
        {
            "type": "Input.ChoiceSet",
            "choices": [
                {
                    "title": "Choice 1",
                    "value": "Choice 1"
                },
                {
                    "title": "Choice 2",
                    "value": "Choice 2"
                }
            ],
            "placeholder": "Placeholder text"
        }
    ]
}

Sample Code Language

No response

Sample Code

No response

@krschau krschau changed the title [Rendering] ChoiceSets without a Label have no accessible name [Rendering][XAML] ChoiceSets without a Label have no accessible name Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant