Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the projects page #97

Open
Emily-Jiang opened this issue Feb 1, 2022 · 8 comments
Open

Fix the projects page #97

Emily-Jiang opened this issue Feb 1, 2022 · 8 comments

Comments

@Emily-Jiang
Copy link
Member

Emily-Jiang commented Feb 1, 2022

Need to fix the following issues:
eclipse/microprofile-marketing#648
eclipse/microprofile-marketing#341
@cesarhernandezgt @secondsun can we meet up to discuss this in more details?

@cesarhernandezgt
Copy link
Member

@cesarhernandezgt @secondsun can we meet up to discuss this in more details?
Sure, looking forward to having the call.

@Emily-Jiang
Copy link
Member Author

@rsoika I have scheduled a call with @cesarhernandezgt and @secondsun to work on your ticket. Please feel free to join the call. The joining info can be found in MP calendar (the only session on Friday)

@secondsun
Copy link
Contributor

Fix for some issues #98

@Dexmaster
Copy link
Contributor

Hello everyone!

Reviewed styling issues:

  • Fixed code tag style to be inline-block with background and reasonable margins (it also applies to our code only as Salient theme uses it for code blocks)
div[ng-view] code {
    padding: 0 5px;
    margin: 2px 0;
    overflow: visible;
    display: inline-block;
    background-color: #f1f4f6 !important;
}

Question now: Should I add github-syntax-light MIT css (https://github.com/primer/github-syntax-light/blob/master/lib/github-light.css) as I see code is already processed for it on API side? (.pl-c .pl-k and other classes)

With css:
image
Without that css:
image

P.S. github-syntax-light is just few lines of css minified:

/*!
 * GitHub Light v0.5.0
 * Copyright (c) 2012 - 2017 GitHub, Inc.
 * Licensed under MIT (https://github.com/primer/github-syntax-theme-generator/blob/master/LICENSE)
 */.pl-c{color:#6a737d}.pl-c1,.pl-s .pl-v{color:#005cc5}.pl-e,.pl-en{color:#6f42c1}.pl-s .pl-s1,.pl-smi{color:#24292e}.pl-ent{color:#22863a}.pl-k{color:#d73a49}.pl-pds,.pl-s,.pl-s .pl-pse .pl-s1,.pl-sr,.pl-sr .pl-cce,.pl-sr .pl-sra,.pl-sr .pl-sre{color:#032f62}.pl-smw,.pl-v{color:#e36209}.pl-bu{color:#b31d28}.pl-ii{color:#fafbfc;background-color:#b31d28}.pl-c2{color:#fafbfc;background-color:#d73a49}.pl-c2::before{content:"^M"}.pl-sr .pl-cce{font-weight:700;color:#22863a}.pl-ml{color:#735c0f}.pl-mh,.pl-mh .pl-en,.pl-ms{font-weight:700;color:#005cc5}.pl-mi{font-style:italic;color:#24292e}.pl-mb{font-weight:700;color:#24292e}.pl-md{color:#b31d28;background-color:#ffeef0}.pl-mi1{color:#22863a;background-color:#f0fff4}.pl-mc{color:#e36209;background-color:#ffebda}.pl-mi2{color:#f6f8fa;background-color:#005cc5}.pl-mdr{font-weight:700;color:#6f42c1}.pl-ba{color:#586069}.pl-sg{color:#959da5}.pl-corl{text-decoration:underline;color:#032f62}

@cesarhernandezgt
Copy link
Member

Thank you @Dexmaster
From your comment, this resolves the rendering issue from the WP Engin CSS.
This confirms my theory that current website doesn't use anymore the Pages from the ec2 app. The only usage of the EC2 app is the REST API.

@Dexmaster
Copy link
Contributor

Oh, Yes it fully uses API, but to add/remove/edit CSS or JS you will need to do it through WP correct.

@secondsun
Copy link
Contributor

Do it through word press or change our CDN rules to use the EC2 app for the docs and projects pages and leave the blog posts on Wordpress.

@cesarhernandezgt
Copy link
Member

The changes with github-syntax-light MIT where applied today to the website. This fixes eclipse/microprofile-marketing#341 and eclipse/microprofile-marketing#648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants