ioredis v5 is not supported yet

[pnutmath]

ioredis v5 is not supported yet with ioredis-lock. What is a plan around it?

[Toilal]

I'm running this library with ioredis v5 and it seems to work properly.

[velles]

It does not work with v5 with typescript.
If it "works" it might be because it's not using v5, but v4 as a dependency and you are not requiring ioredis anywhere on it's own.

Here is one not so great, but working alternative for TypeScript to force ioredis v5 as a dependency all around.
It's not great as @microfleet/ioredis-lock should be natively tested and run CI with ioredis` v5.
Use at your own risk 🤷🏻‍♂️

In package.json

  ...
  "dependencies": {
    "@microfleet/ioredis-lock": "^5.1.0",
    "ioredis": "^5.3.2",
     ....
  }
  "overrides": {
    "@microfleet/ioredis-lock": {
      "ioredis": "$ioredis"
    }
  },

[johnnyshankman]

any updates here? discovered i had a repo running v5 redis with v4 redis lock while swapping it over from yarn to npm today. once i used npm i realized i have conflicting peer dependencies and can't install.

would love to just bump to 5 instead of downgrading redis itself but for now im just downgrading to be safe.

[AVVS]

Main problem is that ioredis 5 uses native promises and 4 uses provider (used bluebird at the time). pr is welcome with support for v5 / removal of bluebird - I can release it if you have time to work on it

[johnnyshankman]

@AVVS awesome, helpful to know the issue. that makes perfect sense. will see if i have some time. a bit swamped at work atm but would love to help out if i find time.