Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon.ico #28

Open
sean-roberts opened this issue Jan 15, 2017 · 7 comments
Open

favicon.ico #28

sean-roberts opened this issue Jan 15, 2017 · 7 comments

Comments

@sean-roberts
Copy link
Collaborator

I've been using chrome to open up views to test and it's requesting for favicon.ico. Is there something we could/should do here? I think this could be a common usage pattern for people trying out the project/testing it.

So some sort of filtering or blacklist?

@mxstbr
Copy link
Member

mxstbr commented Jan 15, 2017

Yeah I've been getting that too, but I think it's largely inconsequential as it only happens when you open the service itself in a browser.

Generally, when used something like this:

fetch('myservice.com/bla')

No favicon visit will be counted, so I think this is fine? It mostly only applies to us developers of micro-analytics.

@sean-roberts
Copy link
Collaborator Author

Yeah, though I think it's worth saying that it will probably apply to any developer looking to see how the service works. Because that's just so easy of a test to play around.

I wonder if there is a way to support user-supplied filtering logic of requests going into the service. I think this is one use case but there might be plenty of others like IP whitelisting, blocking of endpoints that are being abused by a malicious 3rd party, any request that contains a "password" field, etc.

@mxstbr
Copy link
Member

mxstbr commented Jan 15, 2017

Yeah this'll probably tie into #11. Maybe we need some sort of general extensibility?

@sean-roberts
Copy link
Collaborator Author

I think so

@relekang
Copy link
Member

We can maybe add this to the nginx example?

  location = /favicon.ico {
      access_log off;
      log_not_found off;
      return 204;
  }

@sean-roberts
Copy link
Collaborator Author

Not a bad idea either!

@mxstbr
Copy link
Member

mxstbr commented Jan 15, 2017

I like that, simple solution! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants