Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch checkout failure on Windows OS with NTFS #86

Open
VanilleGrobi opened this issue Mar 3, 2024 · 3 comments
Open

branch checkout failure on Windows OS with NTFS #86

VanilleGrobi opened this issue Mar 3, 2024 · 3 comments

Comments

@VanilleGrobi
Copy link

This is probably more a FYI than an actual issue
I'm running emacs on Windows 11, and checkout of the master-branch (onto NTFS) appears to have issues with the "*"-character on these files:

'tests/fixture-deltas/combobulate-envelope-expand-instructions-tsx/component.tsx[choice*-with-complex-missing-field-alt@1~after].tsx'
'tests/fixture-deltas/combobulate-envelope-expand-instructions-tsx/component.tsx[choice*-with-complex-missing-field-consequence@1~after].tsx'
'tests/fixture-deltas/combobulate-envelope-expand-instructions/blank.py[choice*-with-complex-missing-field@1~after].py'

...I didn't see it mentioned anywhere, so, thought it might be worth sharing.

Effectively it leads to package installation failure (for me) using package-vc

(use-package combobulate
  :preface
  ;; You can customize Combobulate's key prefix here.
  ;; Note that you may have to restart Emacs for this to take effect!
  (setq combobulate-key-prefix "C-c o")

  ;; Optional, but recommended.
  ;;
  ;; You can manually enable Combobulate with `M-x
  ;; combobulate-mode'.
  :hook ((python-ts-mode . combobulate-mode)
         (js-ts-mode . combobulate-mode)
         (css-ts-mode . combobulate-mode)
         (yaml-ts-mode . combobulate-mode)
         (json-ts-mode . combobulate-mode)
         (typescript-ts-mode . combobulate-mode)
         (tsx-ts-mode . combobulate-mode)
         )
  :ensure t
  :vc (:url "https://github.com/mickeynp/combobulate" :branch "master")
  )

Doing a manual checkout, I see the following being created instead:

tests/fixture-deltas/combobulate-envelope-expand-instructions-tsx/component.tsx[choice-with-complex-missing-field-alt@1~after].tsx
tests/fixture-deltas/combobulate-envelope-expand-instructions-tsx/component.tsx[choice-with-complex-missing-field-consequence@1~after].tsx
tests/fixture-deltas/combobulate-envelope-expand-instructions/blank.py[choice-with-complex-missing-field@1~after].py

It's my first report, and I do hope the description is sufficient and actually helpful.

@mickeynp
Copy link
Owner

mickeynp commented Mar 3, 2024

Thank you for the report. One workaround is to download the zip of the repo and just not extract the tests --- you won't need them, I don't think.

I'll see about renaming the files.

@VanilleGrobi
Copy link
Author

Np; I can get it working. It's just "an inconvenience".
Thanks a lot.

@AustinMooreT
Copy link

Before these get renamed if someone else wants to clone it you can do the following.

Clone the repo, then after the checkout fails cd into it. Then do the following:

git reset
git config core.protectNTFS false
git checkout

For reference see the following SO post.
https://stackoverflow.com/questions/63727594/github-git-checkout-returns-error-invalid-path-on-windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants