Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mTRFcrossval doesn't work on type='single' and 'fast'=0 #14

Open
mosh-shu opened this issue Jul 23, 2023 · 1 comment
Open

mTRFcrossval doesn't work on type='single' and 'fast'=0 #14

mosh-shu opened this issue Jul 23, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mosh-shu
Copy link

mosh-shu commented Jul 23, 2023

mTRFcrossval doesn't work when typeis 'single' and the 'fast' parameter is 0

xlag produced by lagGen at line 227 and Cxx produced from olscovmat at line 190 does not have the same shape, thus causing an error at line 229.
The xlag at line 227 seems to be a 2-dimensional matrix with the size of (timepoints) * (nChannelsnLags), and Cxx at line 229 seems to be a 3-dimensional matrix of nChannelsnChannelsnLags.
So xlag'xlag at line 230 should give a 2-dimensional matrix with the size of (nChannelsnLags) * (nChannels
nLags); I feel like this matrix should be reshaped to nChannelsnCHannelsnLags?

@mosh-shu mosh-shu added the bug Something isn't working label Jul 23, 2023
@natezuk
Copy link
Collaborator

natezuk commented Jul 24, 2023

Thanks for letting us know about this issue. I was able to replicate it by running single_lag_analysis.m but with the 'fast' parameter set to 0 in mTRFcrossval (line 56). @mickcrosse Can you look into this? I think the issue comes from the way olscovmat and lagGen are used, but I'm not sure of the best way to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants