Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use octokit? #74

Open
NPadrutt opened this issue Jan 13, 2015 · 22 comments
Open

Use octokit? #74

NPadrutt opened this issue Jan 13, 2015 · 22 comments
Labels

Comments

@NPadrutt
Copy link
Collaborator

I just found this library:

https://github.com/octokit/octokit.net

It seems it provides an implementation for a lot who we also need. Therefore it sounds like a good idea to use the library and share development here. Or would this be a too massive change?

@PallasDoesCode
Copy link
Collaborator

It mentions Windows 8 but not Windows Phone. If we did decide to go with something like this we would definitely need to test it first to make sure it's compatible.

@NPadrutt
Copy link
Collaborator Author

sure. I saw in the Issue list that there are already windows phone apps out there who are using it. For example:
http://www.windowsphone.com/de-de/store/app/octocentral/5450b4ca-875b-4d47-8d2a-75004a873f87
(Although this seems to be a WP8.1 Store App and not a 8.1 Silverlight App, but maybe this would also be a consideration).

@AlbertoMonteiro
Copy link
Collaborator

octokit os mantained by The github team, we could test it, I guess that the github windows app use it.

@NPadrutt
Copy link
Collaborator Author

I made a quick test. At least adding works without any problems.

@PallasDoesCode
Copy link
Collaborator

I think it would definitely simplify the project in the long run. The problem I see with using it is there would be a good bit that would need to be changed since this would most likely remove the need for RestSharp.

@NPadrutt
Copy link
Collaborator Author

I think there should be transition time while the existing things can use the existing code and new things can use octokit. But your certainly right that this would mean bigger changes to the project. But IMHO it's worth it.

@PallasDoesCode
Copy link
Collaborator

I think it's definitely worth the time. If we are going to do this, then we should probably make a list of what changes we would want to implement first using Octokit.

@AlbertoMonteiro
Copy link
Collaborator

Agree with @RandomlyKnighted

@NPadrutt
Copy link
Collaborator Author

Agreed. We could make "refactor with octokit"-issues. Or a wikipage.

@PallasDoesCode
Copy link
Collaborator

Why not both? The wiki could also be used for notes that we find on the Octokit project.

@NPadrutt
Copy link
Collaborator Author

good point.

@PallasDoesCode
Copy link
Collaborator

I added a "Refactor-With-Ocotokit" label.

@michelsalib can you add a wiki to the project please?

@AlbertoMonteiro
Copy link
Collaborator

When fixing some issue, I used Octokit, I really love it, much better than use RestSharp!!!
:octocat: Octokit use TPL(async,await) FTW!!!!

@NPadrutt
Copy link
Collaborator Author

Yeah it's really nice to use :)

@AlbertoMonteiro
Copy link
Collaborator

I think we should split views for each developer and refactor everything with Octokit. Since a lot things isn't working properly.

@NPadrutt
Copy link
Collaborator Author

split views for each developer? you mean that everyone takes responsibilty for refactoring some views?

I agree that we have to refactor everything or nearly everything with octokit. The wikipage would be nice to organize it. But for that we need @michelsalib and it seems he isn't very active atm.

@AlbertoMonteiro
Copy link
Collaborator

Yeah, everyone take some view and do the job.
About @michelsalib we could change the main repository to be some of us that are active.
What do you think?

@NPadrutt
Copy link
Collaborator Author

yeah I tend to something like that. I think we should that discuss that in skype. Maybe a bit easier than with comments here

@AlbertoMonteiro
Copy link
Collaborator

I'm eating now when I back to work we can talk if you are available.

@NPadrutt
Copy link
Collaborator Author

Enjoy your meal.
I will be available although only for chat I guess.

@michelsalib
Copy link
Owner

Hey guys, thanks for working on this. I don't really mind moving the repo. Though if we only need to activate the wiki I can gladly do it :)

@michelsalib
Copy link
Owner

Wiki is on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants