Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an argument to make the prompt more minimalistic (shorter) #17

Open
reicolina opened this issue Aug 26, 2015 · 6 comments
Open

Add an argument to make the prompt more minimalistic (shorter) #17

reicolina opened this issue Aug 26, 2015 · 6 comments
Milestone

Comments

@reicolina
Copy link
Contributor

First of all, git-radar is brilliant! 😃 Great Work!

I do notice that the prompt could get quite long, depending of the status of your git project. For example: git:(upstream ⚡long-named-branch xx) 1A 1D1M 1A1 could be a little long.

I wonder if people would be interested in adding an optional --minimal arg to the git-radar command, so when present, both the git: and the remote commits status (i.e: upstream ⚡) will not be shown. The reason i'm suggesting to hide the remote commits status is because i don't rely on it 100% of the time, but again, I'm curious to see what others think.

The other option could be for this --minimal arg to only hide the git: part, and then have another arg --no-remote-status that, if present, will hide the remote commits status part of the prompt.

I will be more than happy to help implementing this feature. Let me know what you think.

Cheers!

@reicolina reicolina changed the title Add a flag to make the prompt more minimalistic (shorter) Add an argument to make the prompt more minimalistic (shorter) Aug 26, 2015
@LazerPanther
Copy link

👍 For --minimal and --no-remote-status

@izelnakri
Copy link

👍 same, it was the first thing I was looking for after installing git-radar.

@reicolina
Copy link
Contributor Author

Thanks for the comments! I'm working on it right now and will submit a PR for review shortly.

@reicolina
Copy link
Contributor Author

Added the --minimal and --no-remote-status args in PR #29. Pending approval.

I noticed that test-files.sh test suite is currently failing (before this changes). I will submit a new issue for that.

@michaeldfallen
Copy link
Owner

Moving this to 0.4 as it seems like a fair bit of work. Would you like me to look at it next week? I have the week travelling for work so my nights will be pretty free.

@reicolina
Copy link
Contributor Author

Hey!..i started looking into this last night and another thing to keep in mind is the color codes to be used for the prompt and how we are going to handle them with the new approach that we discussed. I will be away on vacations for the next 3 days, so feel free to take a look. Just let me know, so we don't work on it, separately, at the same time 😉

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants