Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support project-wide configuration #5

Open
mackwic opened this issue Jul 1, 2014 · 6 comments
Open

Support project-wide configuration #5

mackwic opened this issue Jul 1, 2014 · 6 comments
Milestone

Comments

@mackwic
Copy link
Contributor

mackwic commented Jul 1, 2014

I am still uncertain about the greatest name convention for this (maybe throw it in the package.json ? But which one ?)

Anyway, we need a project-wide configuration. Defaults will be the one shipped with the application, and each value will be overridable.

Proposals for the local config file:

  • .nuwk
  • .config.nuwk
  • ??

Sparse config file are bad. It clutters the file tree with thing we never edit again.
I am all for checking first the dedicated config file, then check for the nuwk key in the package.json, then apply defaults.

What do you think of that ?

@micc83
Copy link
Owner

micc83 commented Jul 1, 2014

I think it fits. About the name i guess .config.nuwk would be more obvious.

@mackwic
Copy link
Contributor Author

mackwic commented Jul 1, 2014

So be it.

@micc83 micc83 added this to the v1.1.0 milestone Jul 2, 2014
@mackwic
Copy link
Contributor Author

mackwic commented Jul 4, 2014

node-runtime-configuration seems to handle the job quiet well, with environment and command lime overloading if necessary.

It will look at .nuwkrc files, though. Rc standing for "runtime configuration". It's ok for me, what do you think ?
By the way, I am pinging the owner of the repo, just to see if he's responsive. If not, I'll fork and we can adapt the project to our needs.

@micc83
Copy link
Owner

micc83 commented Jul 7, 2014

Hi @mackwic, any new from the owner?

@mackwic
Copy link
Contributor Author

mackwic commented Jul 7, 2014

Yep, he’s waiting for my pull request, which is on its way.
Then we’ll just have to nom install his package.

It will probably be ok wednesday.

--  
Thomas Wickham
thomas@wickham.epimeros.org

De: Alessandro Benoit notifications@github.com
Répondre: micc83/Nuwk reply@reply.github.com
Date: 7 juillet 2014 at 15:32:53
À: micc83/Nuwk nuwk@noreply.github.com
Cc: Thomas Wickham thomas@wickham.epimeros.org
Sujet:  Re: [Nuwk] Support project-wide configuration (#5)

Hi @mackwic, any new from the owner?


Reply to this email directly or view it on GitHub.

@micc83
Copy link
Owner

micc83 commented Jul 7, 2014

Cool!

2014-07-07 15:34 GMT+02:00 Thomas Wickham notifications@github.com:

Yep, he’s waiting for my pull request, which is on its way.
Then we’ll just have to nom install his package.

It will probably be ok wednesday.

Thomas Wickham
thomas@wickham.epimeros.org

De: Alessandro Benoit notifications@github.com
Répondre: micc83/Nuwk reply@reply.github.com
Date: 7 juillet 2014 at 15:32:53
À: micc83/Nuwk nuwk@noreply.github.com
Cc: Thomas Wickham thomas@wickham.epimeros.org
Sujet: Re: [Nuwk] Support project-wide configuration (#5)

Hi @mackwic, any new from the owner?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#5 (comment).

Alessandro Benoit
Cel: +39 392 0078370
Email: micc83@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants