Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuwk should be decoupled between cli and gui #4

Open
mackwic opened this issue Jul 1, 2014 · 3 comments
Open

Nuwk should be decoupled between cli and gui #4

mackwic opened this issue Jul 1, 2014 · 3 comments
Milestone
v1.1.0

Comments

@mackwic
Copy link
Contributor

mackwic commented Jul 1, 2014

Nuwk, the gui, is a grat piece fo software. Simple, clean, light.
Nuwk, the API is... still in alpha.

I suggest that we separate the concerns in this way:

  • A npm package which expose the node-webkit management api, shipped with a CLI
  • The actual Nuwk node-webkit, which require the api and make the binding with the view

Also, a cli non-grunt package for building node-webkit is needed.

What do you think ?
@micc83
Copy link
Owner

micc83 commented Jul 1, 2014

I'm glad you took the initiative cause lately i've got so little time to dedicate it.
I'll follow you step by step but, if you wish, you'll have free hand on Nuwk future.

@mackwic
Copy link
Contributor Author

mackwic commented Jul 1, 2014

I'll be happy to contribute and improve the code base as much as I can. But I won't be able to make gui as nice as the one you did. We still need you on the field for the main things. 😉

@micc83
Copy link
Owner

micc83 commented Jul 1, 2014

Good to me! A good opportunity to learn something new 😄

@micc83 micc83 added this to the v1.1.0 milestone Jul 2, 2014
mackwic pushed a commit to mackwic/Nuwk that referenced this issue Jul 4, 2014
Refactoring of model referencing + path finding
a766fa3 
Close micc83#2: node-webkit can be in ~/Application

Changes:
* models.js is no more loadind from brwser context but node.js. Slightly
  cleaner, and prepare the separation gui/npm micc83#4
* path_finder.js knows some paths and try to find the best node-webkit binary in
  the known paths. TODO: Should be configurable.
* use path.join and path-extra for cross-platform paths (mostly path_finder)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@mackwic @micc83