Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unrolled core of blake2 where Argon2 uses the rolled up version #1

Open
mheyman opened this issue Jul 31, 2016 · 1 comment
Open

Comments

@mheyman
Copy link
Owner

mheyman commented Jul 31, 2016

Argon2.FillBlock.cs:FillBlock() uses the simple version of the inner Blake2 algorithm which can be (in theory) dramatically sped up through unrolling. See Blake2BCore-FullyUnrolled.cs for a version to port.

@mheyman
Copy link
Owner Author

mheyman commented Mar 8, 2017

In case anybody cares, the "performance" branch has multiple unrolled options and some timing code. So far, I cannot get reasonable timings on my development system (running in a VM) but it does appear that unrolling in managed code doesn't provide a noticeable improvement and may actually slow things down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant