Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for tox with dotted env #38

Open
gpongelli opened this issue Jan 28, 2023 · 0 comments · May be fixed by #39
Open

support for tox with dotted env #38

gpongelli opened this issue Jan 28, 2023 · 0 comments · May be fixed by #39
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@gpongelli
Copy link
Contributor

as per comment , I'm opening a new issue regarding TOX env with dot inside:

[tox:tox]
isolated_build = true
envlist = lint, format, py3.8, py3.9, py3.10, py3.11, build

looking at the code, a new elif branch should be put here, something like:

    elif env.startswith('py') and '.' in env:
        return Version.from_string(f'{env[2]}.{env[4:]}')

next week I could start a PR on this topic.
@gpongelli gpongelli changed the title support for tax with dotted env support for tox with dotted env Jan 28, 2023
@gpongelli gpongelli linked a pull request Jan 30, 2023 that will close this issue
Open
@mgedmin mgedmin added help wanted Extra attention is needed bug Something isn't working labels Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tox dotted env gpongelli/check-python-versions
2 participants
@mgedmin @gpongelli