Memory leak causing UI lag

[NogaMan]

TL; DR

For a default CD cycle, when routerLink is not a string, but a computed array, the ngOnChange triggers each cycle and pushes new tree into registry, creating major UI lag

Steps to reproduce

• Add routerLink with computed getter value
• Set breakpoint at this.trees.push(tree); in PrefetchRegistry here
• The array keeps growing cyclically

Codesandbox example

The issue can only be reproduced with routerLink value as a getter. If using path arrays hard-coded into template, the problem does not appear.

Images

[NogaMan]

Looks like this issue is a pretty old one #28

Is there any plans to fix it?

[NogaMan]

@mgechev hi! it would be great to see the attached PR reviewed and maybe merged. Thank you in advance!