Add check "Don't use serial"

[mfvanek]

See

• https://stackoverflow.com/questions/55300370/postgresql-serial-vs-identity
• https://wiki.postgresql.org/wiki/Don't_Do_This#Don.27t_use_serial

[manumafe98]

Hi @mfvanek I would like to work on this one!

[mfvanek]

Hi @manumafe98 !
Sure! Feel free to contribute

[manumafe98]

Thanks @mfvanek! I'm needing a bit more information on this one, the goal is to make a test that checks that serial is not being used?

[mfvanek]

@manumafe98
The goal is to help developers migrate to the new syntax when defining primary keys. Instead of old smallserial/serial/bigserial new "generated as identity" syntax should be used.

You need to implement a new sql query to find cases of using old syntax. As example you can use https://github.com/mfvanek/pg-index-health-sql/blob/master/sql/non_primary_key_columns_with_serial_types.sql

Then you need to implement a Java layer above new sql query. A new class have to appear in https://github.com/mfvanek/pg-index-health/tree/master/pg-index-health/src/main/java/io/github/mfvanek/pg/checks/host. See https://github.com/mfvanek/pg-index-health/blob/master/pg-index-health/src/main/java/io/github/mfvanek/pg/checks/host/ColumnsWithSerialTypesCheckOnHost.java as example

[mfvanek]

Hi @manumafe98
Any updates?

[manumafe98]

Hey @mfvanek I'm going to unassign it, currently i'm a bit swamped and I think there is a lot that i should learn to make progress on this issue currently, thanks for the information, maybe I will give it a try in the future if it still open!

[mfaulther]

Hi @mfvanek
May i take this issue ?

[mfvanek]

Hi @mfvanek May i take this issue ?

Yes, sure! I appreciate your help.