New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus instrumentation #115

Open

mfvanek opened this issue Nov 3, 2021 · 1 comment

Labels

Owner

mfvanek commented Nov 3, 2021 •

edited

Consider adding metrics in prometheus format.
We should use Micrometer 1.9.12 (or higher but compatible with Spring Boot 2.7.x)

mfvanek added enhancement help wanted good first issue labels

Owner Author

mfvanek commented Jun 14, 2023

For example see

The most important thing here is that metrics can't be binded during bean creation. It leads to circular dependency. Should use this pattern

    @Override
    public void onApplicationEvent(ApplicationStartedEvent event) {
...
        this.tomcatMetrics.bindTo(this.meterRegistry);
    }

mfvanek removed the good first issue label

mfvanek removed the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment