New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matches_response() implementation for EthernetII / Dot3 #523

Open

markvmk opened this issue Jan 8, 2024 · 0 comments

markvmk commented Jan 8, 2024

Hi,

In both Dot3 and EthernetII implementations of the matches_response(), the same check is done twice:

    if (address_type(header_.src_mac) == address_type(eth_ptr->dst_mac)) {
        if (address_type(header_.src_mac) == address_type(eth_ptr->dst_mac) ||

It seems that the second check is not necessary (probably introducing a bug) or maybe intended to check the second pair of addresses, e.g.

    if (address_type(header_.src_mac) == address_type(eth_ptr->dst_mac)) {
        if (address_type(header_.dst_mac) == address_type(eth_ptr->src_mac) ||

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment