Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reek dependency to newest version #272

Open
obfuscoder opened this issue Jan 25, 2016 · 3 comments
Open

Update reek dependency to newest version #272

obfuscoder opened this issue Jan 25, 2016 · 3 comments

Comments

@obfuscoder
Copy link

Reek has currently version 3.9.1.

In metric_fu the dependency is locked to versions before 3.0.

Is it possible to update the dependency on reek?
@bf4
Copy link
Member

bf4 commented Feb 1, 2016

Yup. Wanna make a PR?

obfuscoder added a commit to obfuscoder/metric_fu that referenced this issue Feb 5, 2016
@obfuscoder
Require reek with version 3.0.0 or later
46b43d7 
Close metricfu#272
@obfuscoder
Copy link
Author

Created PR as requested.

@bf4
Copy link
Member

bf4 commented Feb 5, 2016

@obfuscoder Thanks. I'm not seeing the PR, though

@bf4 bf4 mentioned this issue May 29, 2016
Closed
@bergholdt bergholdt mentioned this issue Sep 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require reek with version 3.0.0 or later obfuscoder/metric_fu
2 participants
@bf4 @obfuscoder