Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.12.0: reek config_file_pattern no longer supported #262

Open
dueckes opened this issue Jun 24, 2015 · 4 comments
Open

4.12.0: reek config_file_pattern no longer supported #262

dueckes opened this issue Jun 24, 2015 · 4 comments
Labels

Comments

@dueckes
Copy link

dueckes commented Jun 24, 2015

After upgrading to 4.12.0, reek no longer appears to be analyzing code when a custom configuration is specified, ala:

    metric.enabled = true
    metric.config_file_pattern = 'config/metrics/reek.yml'

Code is analyzed when the config_file_pattern is omitted.

@bf4
Copy link
Member

bf4 commented Jun 24, 2015

Oops.. @MGotink @ggallen ?

@bf4 bf4 added the bug label Jun 24, 2015
@MGotink
Copy link

MGotink commented Jun 24, 2015

Looks like I've introduced this bug with #258, I'm looking into it.

@MGotink
Copy link

MGotink commented Jun 24, 2015

Hmm, we're passing the config file to the reek examiner here while it no longer needs a config file parameter: troessner/reek@7f4ed2b#diff-c22bbfa18994bc5b1a2f38e7304b7627R13

@andynu
Copy link

andynu commented Feb 28, 2018

As @MGotink mentioned reek reworked its config api. Since a similar behavior can be achieved by placing a *.reek configuration in the current directory (or your home directory) I propose we remove the config_file_pattern configuration option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants