Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider fetching remote env in a different way #2253

Open
Razz4780 opened this issue Feb 21, 2024 · 1 comment
Open

Consider fetching remote env in a different way #2253

Razz4780 opened this issue Feb 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Razz4780
Copy link
Contributor

Currently the agent reads proc filesystem to read env of the target. I imagine an alternative solution, where the env would be taken from Pod template and image

Pros:

  • Would allow to drop CAP_PTRACE from the agent.
  • User application would see the same env as the targeted container at startup. I think it would be better/feel more natural. Consider flows where env is used as key-value store shared between processes (maybe a bit exotic, but we do this ourselves when doing env request from inside layer)
@Razz4780 Razz4780 added the enhancement New feature or request label Feb 21, 2024
@aviramha
Copy link
Member

This is already being done - today, the env is a mix of the proc file and the pod template. The reason behind that is we were too afraid to break it, so we just merged both instead of replacing. Nowaday I know some users have entry points that add/change env and it might be useful, also some env is provided by k8s itself on start (see all the "SERVICE" env names - not in spec but do exist in the container itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants