Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete prettyPrinting option for encode-yaml in documentation #19

Open
TobiasNx opened this issue Jun 2, 2022 · 7 comments
Open

Delete prettyPrinting option for encode-yaml in documentation #19

TobiasNx opened this issue Jun 2, 2022 · 7 comments
Assignees
@TobiasNx
Projects
Metafacture alt

Comments

@TobiasNx
Copy link
Collaborator

TobiasNx commented Jun 2, 2022

This option is not supported. So I would just delete it.
TobiasNx added a commit that referenced this issue Jun 2, 2022
@TobiasNx
Delete prettyPrinting option for encode-yaml docu
aab8e74 
#19
@TobiasNx TobiasNx mentioned this issue Jun 2, 2022
Closed
@blackwinter
Copy link
Member

Background: Jackson's YAMLGenerator ignores any PrettyPrinter (and in version 3 it's completely gone). There is a feature request (FasterXML/jackson-dataformats-text#43) that might help in this regard, but it hasn't been implemented yet.

dr0i added a commit to metafacture/metafacture-core that referenced this issue Jun 2, 2022
@dr0i
Remove parameter "prettyPrinting"
f8d05f0 
See metafacture/metafacture-documentation#19.
@dr0i dr0i mentioned this issue Jun 2, 2022
Closed
@dr0i
Copy link
Member

dr0i commented Jun 2, 2022

The option is supported , as it always does pretty printing. It's just superfluous.

@blackwinter
Copy link
Member

The option is supported , as it always does pretty printing.

But you can't disable pretty printing as the documentation suggests.

@dr0i
Copy link
Member

dr0i commented Jun 2, 2022

Ah, I see. Yeah, that should be noted somehow.

dr0i added a commit to metafacture/metafacture-core that referenced this issue Jun 2, 2022
@dr0i
Deprecate parameter "prettyPrinting"
600aa2a 
Jackson's YAMLGenerator ignores any PrettyPrinter. It's always
pretty printed.

- mark methods as deprecated
- note deprecation in description
- update test

See metafacture/metafacture-documentation#19.
@dr0i dr0i mentioned this issue Jun 2, 2022
Merged
@dr0i
Copy link
Member

dr0i commented Jun 2, 2022

Closed in favour of metafacture/metafacture-core#447.

@dr0i dr0i closed this as completed Jun 2, 2022
@dr0i dr0i reopened this Jun 2, 2022
@dr0i
Copy link
Member

dr0i commented Jun 2, 2022

Sorry, not the issue should be closed, but another PR.

@dr0i dr0i added this to Working in Metafacture alt Jun 2, 2022
@TobiasNx TobiasNx mentioned this issue Jun 2, 2022
Closed
@dr0i
Copy link
Member

dr0i commented Jun 2, 2022

Updated https://github.com/metafacture/metafacture-documentation/blob/master/flux-commands.md#encode-yaml .

@dr0i dr0i moved this from Working to Review in Metafacture alt Jun 2, 2022
blackwinter added a commit to metafacture/metafacture-core that referenced this issue Jun 2, 2022
@blackwinter
Mark deprecated Flux command options in help output. (metafacture/met…
2ad7734 
…afacture-documentation#19. #447)
@blackwinter blackwinter mentioned this issue Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TobiasNx TobiasNx

Labels
None yet
Projects
No open projects
Metafacture alt
Review
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blackwinter @dr0i @TobiasNx