Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): Allow cluster resources in related result #843

Closed

Conversation

newtondev
Copy link
Collaborator

Fixes #842

Signed-off-by: Craig Newton <newtondev@gmail.com>
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #843 (9415597) into master (3059272) will increase coverage by 0.21%.
Report is 2 commits behind head on master.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   52.04%   52.26%   +0.21%     
==========================================
  Files          63       63              
  Lines        5224     5206      -18     
==========================================
+ Hits         2719     2721       +2     
+ Misses       2241     2224      -17     
+ Partials      264      261       -3     
Flag Coverage Δ
integration-test 43.45% <85.71%> (-0.01%) ⬇️
unit-test 31.96% <85.71%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/controller/common/customize/manager.go 57.61% <0.00%> (+2.44%) ⬆️
pkg/controller/common/api/v2/common.go 71.23% <100.00%> (+6.84%) ⬆️
pkg/controller/composite/api/v1/hooks.go 88.88% <100.00%> (ø)
pkg/controller/decorator/api/v1/hooks.go 81.48% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Craig Newton <newtondev@gmail.com>
@newtondev
Copy link
Collaborator Author

This could potentially cause data to leak unintentionally. The main use case for this is to get a list of the namespaces in a customize hook to return the labels and annotations thereof when using a Namespaced controller. I could update the code to allow for that as the unintentional behavior introduced with this change, could potentially get sensitive information like secrets.

@newtondev newtondev closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 4.10.3 and up related to the customize hook
1 participant