Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests - migrate to controller-runtime env test #782

Open
grzesuav opened this issue Apr 19, 2023 · 5 comments
Open

Integration tests - migrate to controller-runtime env test #782

grzesuav opened this issue Apr 19, 2023 · 5 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing

Comments

@grzesuav
Copy link
Contributor

Currently integration tests are :

  • downloading kube-apiserver, etcd, kubectl binary
  • starts them
  • install crds
  • registers decorator/composite webhooks
  • create resources and wait for results

The problematic part is managing binaries and the workflow.

Idea is to migrate to https://book.kubebuilder.io/reference/envtest.html and https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/envtest
as we would get rid of the burden of managing the binaries, also it provides some utility methods

@grzesuav grzesuav added good first issue Good for newcomers help wanted Extra attention is needed testing labels Apr 19, 2023
@newtondev
Copy link
Collaborator

@grzesuav I can pick this one up, happy to discuss further on Slack if need be.

@grzesuav
Copy link
Contributor Author

@newtondev feel free to pick it up, we have several functional tests which I think can be replaced by envtest, feel free to ping me on slack for discussion

@newtondev
Copy link
Collaborator

/assign

@newtondev
Copy link
Collaborator

Progress is coming along quite well. I have a small PoC that I will submit for review shortly.

@grzesuav
Copy link
Contributor Author

sounds great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing
Projects
None yet
Development

No branches or pull requests

2 participants