Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status field not being updated for the attachment resource #766

Open
Shashankft9 opened this issue Mar 16, 2023 · 1 comment
Open

Status field not being updated for the attachment resource #766

Shashankft9 opened this issue Mar 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Shashankft9
Copy link

I have noticed when I use a DecoratorController, and try to send the response with status for an attachment resource, although it gets reflected in the attachment resource for the very first time, but for the subsequent updates in the status field of this attachment resource, metacontroller just ignores doing any changes - its even missing in the mergepatch calculated.

sample logs from metacontroller:
in request i see this: (expected)

"status":{"conditions":[{"lastTransitionTime":"2023-03-06T10:23:53Z","status":"True","type":"CUD"}]}}}},"related":{},"finalizing":false}}

in response i see this: (expected)

"status":{"conditions":[{"type":"CUD","status":"True","lastTransitionTime":"2023-03-09T07:31:52Z"}]}}]}}

Notice the time change in the request and response.
Now, in this log, metacontroller gives the expected change in spec in attachment cr, but I cant see the status bit here

{"level":"Level(-5)","ts":1678347112.267575,"msg":"Diff between observed and desired","mergePatch":{"spec":{"data":"{\"maxclients\":\"9800\",\"repl-ping-replica-period\":\"10\"},,\"runAsNonRoot\":true,\"runAsUser\":7777777}}"}}}
@grzesuav
Copy link
Contributor

grzesuav commented Apr 8, 2023

hi @Shashankft9 , I saw #776, however this is not the way how I would like to handle it, as it is arbitrary changing the behawior. In some cases people do not controll the races in resources.

I would see that it will be controllable behaviour per child/attachement, so change in the config API, I still need to wrap an idea regarding this, as have some other config related changes in API types (i.e. emitting events)

@grzesuav grzesuav added the enhancement New feature or request label Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants