Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log wrong webhook url error. #587

Open
timdevlet opened this issue Aug 9, 2022 · 1 comment
Open

Log wrong webhook url error. #587

timdevlet opened this issue Aug 9, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@timdevlet
Copy link

Hello. I need to count all errors with Prometheus. Imagine you have a domain in CompositeController.

  hooks:
     sync:
       webhook:
         etag:
           enabled: true
         url: https://domain.com/sync?foo=bar
   parentResource:

If you have the wrong parameter https://domain.com/**sinc** (sinc VS sync) this query can log this:

sum by (cluster, domain, code, instance) (rate (metacontroller_sync_requests_total {cluster=~"$Cluster", domain=~"$Domain", instance=~"$Instance", **code**!="200"}[10m] ) ) > 0

But if you have an error in the domain name ( wrongdomain.com VS domain.com), the error doesn't store in the metacontroller_sync_requests_total.

I can't catch this behavior (invalid domain name in webhook) and track it down.

in my opinion we need a simple mechanism to count all errors that we see in the logs.

@grzesuav grzesuav added the enhancement New feature or request label Aug 10, 2022
@grzesuav
Copy link
Contributor

hi @timdevlet , which error is reported when url is wrong ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants