Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apply): Preserve order of entries in list map #646

Closed
wants to merge 1 commit into from
Closed

fix(apply): Preserve order of entries in list map #646

wants to merge 1 commit into from

Conversation

grzesuav
Copy link
Contributor

@grzesuav grzesuav commented Sep 7, 2022

Fixes #562

@grzesuav
fix(apply): Preserve order of entries in list map
c1f72bf 
Fixes metacontroller#562

Signed-off-by: Grzegorz Głąb <grzesuav@gmail.com>
@codecov
Copy link

codecov bot commented Sep 7, 2022 •
edited

Codecov Report

Merging #646 (c1f72bf) into master (d056493) will decrease coverage by 7.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   50.60%   43.17%   -7.43%     
==========================================
  Files          62       53       -9     
  Lines        5118     4866     -252     
==========================================
- Hits         2590     2101     -489     
- Misses       2272     2492     +220     
- Partials      256      273      +17
Flag Coverage Δ
integration-test 43.17% <ø> (+0.32%) ⬆️
unit-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/composite/api/v1/hooks.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/hooks/webhook_etag.go 0.00% <0.00%> (-78.38%) ⬇️
pkg/controller/common/diff.go 0.00% <0.00%> (-42.31%) ⬇️
...s/metacontroller/v1alpha1/zz_generated.deepcopy.go 27.46% <0.00%> (-32.47%) ⬇️
pkg/controller/common/manage_children.go 45.67% <0.00%> (-26.45%) ⬇️
pkg/controller/common/api/v1/common.go 61.53% <0.00%> (-11.54%) ⬇️
pkg/dynamic/apply/apply.go 70.27% <0.00%> (-11.49%) ⬇️
pkg/controller/decorator/controller.go 49.72% <0.00%> (-6.40%) ⬇️
pkg/controller/common/common.go 73.07% <0.00%> (-5.13%) ⬇️
pkg/dynamic/clientset/clientset.go 54.95% <0.00%> (-4.51%) ⬇️
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@grzesuav grzesuav closed this Nov 15, 2022
@grzesuav grzesuav deleted the 562-preservefieldorder branch November 15, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

environment var array order not being respected
1 participant
@grzesuav