allow users to load custom hmm model #92
Conversation
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 86.41% 87.59% +1.17%
==========================================
Files 8 7 -1
Lines 1067 693 -374
==========================================
- Hits 922 607 -315
+ Misses 145 86 -59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
I don't believe this is the best way to do it. How about making viterbi a method of HmmModel and let Jieba own a HmmModel?
struct Jieba {
hmm_model: Option<HmmModel>,
...
}
impl Jieba {
pub fn set_hmm_model(&mut self, hmm_model: HmmModel) -> &mut Self {
...
}
}
struct HmmModel {
...
}
impl HmmModel {
pub fn new(..) -> Self {
todo!()
}
}
#[cfg(feature = "default-hmm-model")]
impl Default for HmmModel {
fn default() -> HmmModel {
// load default hmm model
}
}| cedarwood = "0.4" | ||
| ordered-float = { version = "3.0", optional = true } | ||
| once_cell = "1" |
There was a problem hiding this comment.
There is no point in use both lazy_static and once_cell, please also replace lazy_static with once_cell
| @@ -30,17 +30,18 @@ required-features = ["tfidf", "textrank"] | |||
| regex = "1.0" | |||
| lazy_static = "1.0" | |||
| phf = "0.11" | |||
| hashbrown = { version = "0.12", default-features = false, features = ["inline-more"] } | |||
There was a problem hiding this comment.
This would need a benchmark result to justify it.
There was a problem hiding this comment.
I'm wondering if instead HMMModel should be a seprate struct and that Jieba's interface should be expanded to be
cut()
hmm_cut()
Will discussion back in #48
close #48