Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease stuttering in providers #53

Open
epels opened this issue Sep 28, 2018 · 0 comments
Open

Decrease stuttering in providers #53

epels opened this issue Sep 28, 2018 · 0 comments
Milestone

Comments

@epels
Copy link
Contributor

epels commented Sep 28, 2018

All providers live in their own package, but many types also contain the provider name.

The result is code like this:

provider := messagebird.NewMessageBird(messagebird.MessageBirdConfig{
    AccessKey: "YOUR_ACCESS_KEY",
    // ...
})

I'd like to propose dropping these redundant prefixes in type names, which looks a lot cleaner:

provider := messagebird.New(messagebird.Config{
    AccessKey: "YOUR_ACCESS_KEY",
    // ...
})

The messagebird package is only an example - this applies to nearly all other providers.

This is obviously a breaking change, so I'll set the milestone for this to v1.0.0.

@epels epels added this to the v1.0.0 milestone Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant