Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSV-443 messagebird/pushprom does not respect log-level argument #32

Open
sshilko opened this issue Dec 2, 2022 · 2 comments
Open

Comments

@sshilko
Copy link

sshilko commented Dec 2, 2022

The problem

Pushprom 1.0.8 is too verbose on default INFO level.

Trying to use the “documented” -log-level argument for the application does not have effect.

Update from 1.0.7 to 1.0.8 resulting in thousands unnecessary log records polluting the INFO logs.

Definition of Done

Pushprom 1.0.8 does not change behaviour when updating from 1.0.7 for logging.

or Pushprom 1.0.8 default verbosity level changes to “warn” and/or respect the -log-level documented argument.

https://github.com/messagebird/pushprom/tree/1.0.8

@sshilko
Copy link
Author

sshilko commented Dec 2, 2022

I will submit the MR with the fix myself :)

@sshilko
Copy link
Author

sshilko commented Dec 5, 2022

Please review #33

Behaviour change:

  • UDP listener now listens with timeout of 1 second, inside infinite loop, previously no timeout causes inifinite block.
  • HTTP listener write & read-header timeouts of 10 seconds, previously no timeouts
  • Log messages are now split between STDERR and STDOUT, previously all "log" messages went to STDERR
  • Previously HTTP& UDP servers were never gracefully shutdown, now they react to SIGINT, SIGTERM (no SIGQUIT)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant