Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the isPlainObject can be improved because it has missed Object.create(null) #83

Open
aswind7 opened this issue Aug 17, 2023 · 2 comments

Comments

@aswind7
Copy link

aswind7 commented Aug 17, 2023

image

it can be this:

export function isPlainObject(payload: any): payload is PlainObject {
  if (getType(payload) !== 'Object') return false
  const prototype = Object.getPrototypeOf(payload)
  if (prototype === null) return true
  return prototype.constructor === Object && prototype === Object.prototype
}
@R00T80Y
Copy link

R00T80Y commented Feb 6, 2024

export function isPlainObject(payload: any): payload is PlainObject {
  if (getType(payload) !== 'Object') return false
  const prototype = Object.getPrototypeOf(payload)

  // Fix
  if (prototype === null) return true;

  return !!prototype && prototype.constructor === Object && prototype === Object.prototype
}

@R00T80Y
Copy link

R00T80Y commented Feb 7, 2024

I find in test this. Why?

expect(isPlainObject(Object.create(null))).toEqual(false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants