Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More edge-case tests #71

Open
Tracked by #68
jcbhmr opened this issue Jun 3, 2023 · 1 comment
Open
Tracked by #68

More edge-case tests #71

jcbhmr opened this issue Jun 3, 2023 · 1 comment

Comments

@jcbhmr
Copy link
Collaborator

jcbhmr commented Jun 3, 2023

Example for things like isString():

  • Object.create(String.prototype)
  • new String()
  • new class extends String {}
  • new iframe.contentWindow.String()
  • { [Symbol.toStringTag]: "String" }
  • new class String {}
  • new class String { [Symbol.toStringTag] = "String" }
  • new (iframe.contentWindow.eval("class String { [Symbol.toStringTag] = 'String' }"))()

@mesqueeb Thoughts on what each of these edge-cases should return?

@jcbhmr jcbhmr mentioned this issue Jun 3, 2023
15 tasks
@mesqueeb
Copy link
Owner

mesqueeb commented Jun 6, 2023

this is literally all JavaScript i've never used in my life so I don't really know or care too much tbh XD

Whatever you think is best is probably OK. I have no strong feelings as I use pretty basic JavaScript syntax in my code. Readability ftw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants