Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*taskID*.slave.mesos can be an invalid A record. #509

Open
drewkerrigan opened this issue Oct 9, 2017 · 0 comments
Open

*taskID*.slave.mesos can be an invalid A record. #509

drewkerrigan opened this issue Oct 9, 2017 · 0 comments

Comments

@drewkerrigan
Copy link
Contributor

When lookup fails in generator.go's slaveRecords for slave.PID.Host, we default to using labels.DomainFrag(slave.PID.Host, labels.Sep, spec) for the rg.SlaveIPs[slave.ID] value.

Later in taskContextRecord, we use that for *taskID*.slave.mesos records. A test case for this and possibly a fix should be created so that invalid A records are not created in this situation.

My suspicion is that a failure would occur later on down the line because resolver.go will attempt a .To4() on all A records which should fail this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant